apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] WIN64: apr_pools.c
Date Tue, 05 Oct 2004 21:28:39 GMT
On Tue, 05 Oct 2004 14:02:20 -0400, Allan Edwards <ake1@us.ibm.com> wrote:
> > I'm like Jeff, I won't lose any sleep if we just say that
> > 64 bit APR 1.0 cannot handle very large memory objects and go
> > the path of validating restricting and casting. At least let's
> > pursue that path and see how ugly it gets.
> 
> Going with plan 'B'... I tend to think it would be useful to
> use a #define for any 64bit warning-quieting casts so that they
> can be easily identified & ripped out for APR 2.0 - comments?
> 
> Allan
> 
> Index: srclib/apr/include/apr.h.in

I'd suggest

APR_32BIT_TRUNC_CAST

defined only in private headers only so that 

a) we don't add yet more symbols to API
b) we continually identify where our API is broken w.r.t. handling
quantities properly in a 64-bit world

Mime
View raw message