apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: cvs commit: apr/memory/unix apr_pools.c
Date Fri, 08 Oct 2004 22:17:36 GMT
--On Friday, October 8, 2004 4:31 PM +0100 Joe Orton <jorton@redhat.com> wrote:

> I think comments would be much clearer because they'd remove the "huh?"
> factor when you read the code for the first time without knowing what
> the macro means.  But I don't care enough to go and revert the changes
> and probably nobody else is paying attention so I guess let's give up
> and go do something useful.

FWIW, I agree with Joe.  The casts are evil in this particular case and 
serious consideration should be made to backing it out.  We should just track 
it in STATUS instead...  -- justin

Mime
View raw message