Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 72964 invoked from network); 1 Oct 2004 17:25:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Oct 2004 17:25:09 -0000 Received: (qmail 37875 invoked by uid 500); 1 Oct 2004 17:25:06 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 37845 invoked by uid 500); 1 Oct 2004 17:25:06 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 37832 invoked by uid 99); 1 Oct 2004 17:25:06 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=SPF_HELO_PASS,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Message-Id: <6.0.3.0.2.20041001132033.02137780@mail.charter.net> X-Sender: gregmm@mail.charter.net X-Mailer: QUALCOMM Windows Eudora Version 6.0.3.0 Date: Fri, 01 Oct 2004 13:21:30 -0400 To: "Jean-Jacques Clar" From: Greg Marr Subject: Re: cvs commit: apr/network_io/win32 sendrecv.c Cc: In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Mail-Handler: MailHop Outbound by DynDNS.org X-Originating-IP: 66.181.95.131 X-Report-Abuse-To: abuse@dyndns.org (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: gregmm X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N At 01:06 PM 10/1/2004, Jean-Jacques Clar wrote: > >>> "William A. Rowe, Jr." 09/28/04 5:10 PM >>> > >#ifdef DWORD_MAX > >#define APR_DWORD_MAX DWORD_MAX > >#else > >#define DWORD_MAX 4294967295UL > >#endif > >What about: > >#ifndef DWORD_MAX >#define DWORD_MAX 4294967295UL /* 2^32*/ >#endif > >#define APR_DWORD_MAX DWORD_MAX I assume that Bill meant to write: #ifdef DWORD_MAX #define APR_DWORD_MAX DWORD_MAX #else #define APR_DWORD_MAX 4294967295UL #endif or as someone else posted #ifdef DWORD_MAX #define APR_DWORD_MAX DWORD_MAX #else #define APR_DWORD_MAX 0xFFFFFFFFUL #endif Defining DWORD_MAX at all could cause problems if it was defined by a later header file.