Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 48951 invoked from network); 29 Sep 2004 19:05:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 29 Sep 2004 19:05:12 -0000 Received: (qmail 84717 invoked by uid 500); 29 Sep 2004 19:05:10 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 84664 invoked by uid 500); 29 Sep 2004 19:05:09 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 84650 invoked by uid 99); 29 Sep 2004 19:05:09 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=DNS_FROM_RFC_ABUSE,UPPERCASE_25_50 X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Message-ID: <415B06C1.4040301@us.ibm.com> Date: Wed, 29 Sep 2004 15:02:25 -0400 From: Allan Edwards User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: cvs commit: apr/network_io/win32 sendrecv.c References: <20040928161617.74570.qmail@minotaur.apache.org> <6.1.2.0.2.20040928180557.02a67a00@pop3.rowe-clan.net> In-Reply-To: <6.1.2.0.2.20040928180557.02a67a00@pop3.rowe-clan.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 29 Sep 2004 19:02:25.0734 (UTC) FILETIME=[DBBEF660:01C4A656] X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N William A. Rowe, Jr. wrote: > #ifdef DWORD_MAX > #define APR_DWORD_MAX DWORD_MAX > #else > #define DWORD_MAX 4294967295UL > #endif > > it seems we forgot to correctly sign this constant Definitely should use correct sign, but since Windows DWORD_MAX is not defined as UL I'm inclined to just ignore DWORD_MAX, but use the possibly clearer hex notation for APR_DWORD_MAX thus #define APR_DWORD_MAX 0xFFFFFFFFUL Allan