apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: cvs commit: apr/threadproc/win32 thread.c
Date Thu, 23 Sep 2004 10:25:43 GMT
On 23 Sep 2004 06:17:59 -0000, mturk@apache.org <mturk@apache.org> wrote:
> mturk       2004/09/22 23:17:59
> 
>   Modified:    threadproc/win32 Tag: APR_0_9_BRANCH thread.c
>   Log:
>   Backport from HEAD.
>   Makes the threads to behave like on posix. If the thread is created without
>   APR_DETACH expect that the thread_join will be called, so don't close the
>   handle in advance, if the thread has already finished.
>   Reviewed by:  wrowe

you've got some isolated CR characters in your commit that need to be
cleaned up; here is one example:

    if ((*new) == NULL) {
        return APR_ENOMEM;
    }

    (*new)->pool = pool;
    (*new)->detach = 0;^M         <----------

    return APR_SUCCESS;
}

also, if committing CHANGES separately from thread.c was intentional,
please try to commit them together in the future so that the related
change appears in the same commit log

if you have a broken cvs client which fails to commit files in the
current directory if there are other files to commit as well, you can
change to .. and do a commit on (for example) "apr/CHANGES
apr/threadproc/win32/thread.c" to work around the bogosity

Mime
View raw message