apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: cvs commit: apr/atomic/win32 apr_atomic.c
Date Mon, 20 Sep 2004 19:44:09 GMT
On Mon, 20 Sep 2004 ake@apache.org wrote:

> ake         2004/09/20 12:20:12
>
>   Modified:    atomic/win32 apr_atomic.c
>   Log:
>   WIN64: avoid unresolved external error with 64 bit build

>    {
>   +#if (defined(_M_IA64) || defined(_M_AMD64))
>   +    return InterlockedExchangeAdd(mem, val);
>   +#else
>        return ((apr_atomic_win32_ptr_val_fn)InterlockedExchangeAdd)(mem, val);
>   +#endif
>    }


Doesn't this just mean that the definition of apr_atomic_win32_ptr_val_fn
is wrong on win64?  Wouldn't it be cleaner to redefine that on win64
instead of these two #if #else cases?

--Cliff

Mime
View raw message