apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Allan Edwards <a...@us.ibm.com>
Subject Re: cvs commit: apr/network_io/win32 sendrecv.c
Date Wed, 29 Sep 2004 19:02:25 GMT
William A. Rowe, Jr. wrote:
> #ifdef DWORD_MAX
> #define APR_DWORD_MAX DWORD_MAX
> #else
> #define DWORD_MAX 4294967295UL
> #endif
> 
> it seems we forgot to correctly sign this constant

Definitely should use correct sign, but since
Windows DWORD_MAX is not defined as UL I'm inclined
to just ignore DWORD_MAX, but use the possibly
clearer hex notation for APR_DWORD_MAX thus

#define APR_DWORD_MAX 0xFFFFFFFFUL

Allan

Mime
View raw message