apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: renaming apr_file_open_flags group defines
Date Mon, 20 Sep 2004 00:19:26 GMT
[don't forget to Reply-All]

William A. Rowe, Jr. wrote:
> At 05:02 PM 9/19/2004, you wrote:
>>William A. Rowe, Jr. wrote:
>>>>Not sure what's the best prefix here. Is APR_OPEN_ good? APR_OPEN_READ, APR_OPEN_WRITE,
>>>About this group - smakes sense to me unless these flags are 'generic',
>>>e.g. apply-to other.  And no, APR_OPEN_ isn't ideal, but APR_FILE_OPEN_
>>>would be. 
>>So now that the veto has been removed, what's the best prefix to use? APR_FILE_OPEN_?
APR_FOPEN_? other?
> There is no such apr_open_* today, so that would be wrong.
> APR_FILE_OPEN_* is right.  But I'm not seeing anyone but you and I
> advocating for it.

FILE_OPEN_ is inconsistent with other file defines. It's usually FFOO, as 
in FINFO, so APR_FOPEN_ makes more sense, IMHO

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

View raw message