apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] WIN64: apr_pools.c
Date Wed, 29 Sep 2004 22:00:52 GMT
On Wed, Sep 29, 2004 at 05:35:34PM -0400, Allan Edwards wrote:
> In order to eliminate the following warnings for Win64 builds the
> appended patch is needed. However this changes fields in the apr_memnode_t
> structure in apr/include/apr_allocator.h
> 
> Seems that this strucure really should be private and moved along
> with struct apr_allocator_t to include/arch/unix/apr_arch_allocator.h
> but either moving it or changing it may be construed as changing
> the 1.0 API. Personally I don't think so but if anyone thinks
> otherwise let's discuss.

It is part of the API, it can't be changed like this in 1.x.  You can't
use the apr_allocator_* API without using the apr_memnode_t structure,
so I don't see how it could be made private either.

> @@ -53,8 +53,8 @@
>  struct apr_memnode_t {
>      apr_memnode_t *next;            /**< next memnode */
>      apr_memnode_t **ref;            /**< reference to self */
> -    apr_uint32_t   index;           /**< size */
> -    apr_uint32_t   free_index;      /**< how much free */
> +    apr_size_t     index;           /**< size */
> +    apr_size_t     free_index;      /**< how much free */
>      char          *first_avail;     /**< pointer to first free memory */
>      char          *endp;            /**< pointer to end of free memory */
>  };


Mime
View raw message