apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jani Averbach <...@jaa.iki.fi>
Subject Re: [PATCH] Add BDB 4.3 support to the apr-util/build/dbm.m4
Date Thu, 23 Sep 2004 14:36:58 GMT
On 2004-09-23 13:26+0100, Joe Orton wrote:
> On Tue, Sep 21, 2004 at 07:59:19PM -0600, Jani Averbach wrote:
> > This patch adds support for 'sometime in the future to be released'
> > Berkeley DB 4.3.
> 
> a.k.a. make apr-util/configure another three times slower :)
> 

No comments. =)

> Thanks Jani, committed to HEAD, I guess it applies the same to 0.9.x and
> should be done there too...

There is one little difference:

0.9.x:
  APU_CHECK_BERKELEY_DB("4", "1", "-1",
    "$places",
    "db41/db.h db4/db.h db.h",
    "db-4.1 db4 db"
  )
...
  APU_CHECK_BERKELEY_DB("4", "2", "-1",
    "$places",
    "db42/db.h db4/db.h db.h",
    "db-4.2 db4 db"
  )


When 1.0.x uses:
  APU_CHECK_BERKELEY_DB("4", "1", "-1",
    "$places",
    "db41/db.h db4/db.h db.h",
    "db-4.1 db41 db4 db"
  )         ^^^^
...
  APU_CHECK_BERKELEY_DB("4", "2", "-1",
    "$places",
    "db42/db.h db4/db.h db.h",
    "db-4.2 db42 db4 db"
  )         ^^^^

I don't know why there is this difference. So, if it was there by
intention, then the patch should be changed to use:

  APU_CHECK_BERKELEY_DB("4", "3", "-1",
    "$places",
    "db43/db.h db4/db.h db.h",
    "db-4.3 db4 db"
  )

if not, perhaps we should haul the whole file from 1.0.x to the 0.9.x? 

*shrug*

BR, Jani

-- 
Jani Averbach

Mime
View raw message