Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 44980 invoked from network); 3 Aug 2004 23:36:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 3 Aug 2004 23:36:41 -0000 Received: (qmail 7765 invoked by uid 500); 3 Aug 2004 23:36:39 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 7732 invoked by uid 500); 3 Aug 2004 23:36:39 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 7717 invoked by uid 99); 3 Aug 2004 23:36:38 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Message-Id: X-Mailer: Novell GroupWise Internet Agent 6.5.2 Beta Date: Tue, 03 Aug 2004 17:36:15 -0600 From: "Brad Nicholes" To: Cc: Subject: Re: apr_ldap macro fooness is gone Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Are all platforms suppose to be using apr_ldap_url_parse() from apr_ldap_url.c rather than the native call to ldap_url_parse()? If so then then I'm not sure how you got apr_ldap_url.c to compile. APU_DECLARE(int) apr_ldap_url_parse(apr_pool_t *pool, const char *url_in, apr_ldap_url_desc_t **ludpp, apr_ldap_err_t **result_err) { int rc = ldap_url_parse_ext(pool, url_in, ludpp, result_err); <--***Should be a call to apr_ldap_url_parse_ext()*** if( rc != APR_SUCCESS ) { return rc; } if ((*ludpp)->lud_scope == -1) { (*ludpp)->lud_scope = LDAP_SCOPE_BASE; } if ((*ludpp)->lud_host != NULL && *(*ludpp)->lud_host == '\0') { (*ludpp)->lud_host = NULL; } return rc; } Line #584 should be a call to apr_ldap_url_parse_ext() rather than ldap_url_parse_ext() correct? Otherwise it conflicts with the native prototype. Brad Brad Nicholes Senior Software Engineer Novell, Inc., the leading provider of Net business solutions http://www.novell.com >>> Graham Leggett Tuesday, August 03, 2004 5:05:31 PM >>> Graham Leggett wrote: > I'm busy giving apr_ldap_url the full APR treatment - allocate memory > from pools, etc. There'll be no need to use the native ldap URL parse > routines any more. It's in and compiles against openldap v2. Please can someone check that the Windows and Netware builds also work. Regards, Graham --