Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 89485 invoked from network); 26 Aug 2004 23:00:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 26 Aug 2004 23:00:29 -0000 Received: (qmail 93145 invoked by uid 500); 26 Aug 2004 23:00:28 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 92870 invoked by uid 500); 26 Aug 2004 23:00:26 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 92843 invoked by uid 99); 26 Aug 2004 23:00:26 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Date: Thu, 26 Aug 2004 19:00:22 -0400 (EDT) From: Cliff Woolley X-X-Sender: jcw5q@cobra.cs.Virginia.EDU cc: dev@apr.apache.org Subject: Re: RC6 take 2 In-Reply-To: <20040826212019.GA3528@dragon.toftum.org> Message-ID: References: <412D9AC2.20302@jetnet.co.uk> <4A20D3B2-F796-11D8-806F-000D9337BE56@clove.org> <20040826212019.GA3528@dragon.toftum.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Has anybody gotten apr-util to compile with apr-iconv? I get the following on win32 when building apr-util with apr and apr-iconv all present: apr-util\xlate\xlate.c(181): error C2198: 'apr_iconv_close' : too few arguments for call through pointer-to-function apr-util\xlate\xlate.c(182): error C2198: 'apr_iconv_open' : too few arguments for call through pointer-to-function apr-util\xlate\xlate.c(182): warning C4047: '=' : 'apr_iconv_t' differs in levels of indirection from 'apr_status_t' It would be a two line fix to xlate.c to get rid of this problem. Honestly it seems unlikely anybody's ever even attempted to compile on this path, so I'm not sure if I care. And in any event, other than that it looks good. +1 with or without a fix. --Cliff