apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: apr_ldap macro fooness is gone
Date Tue, 03 Aug 2004 23:36:15 GMT
  Are all platforms suppose to be using apr_ldap_url_parse() from
apr_ldap_url.c rather than the native call to ldap_url_parse()?  If so
then then I'm not sure how you got apr_ldap_url.c to compile.

APU_DECLARE(int) apr_ldap_url_parse(apr_pool_t *pool,
                                    const char *url_in,
                                    apr_ldap_url_desc_t **ludpp,
                                    apr_ldap_err_t **result_err)
{

    int rc = ldap_url_parse_ext(pool, url_in, ludpp, result_err); 
<--***Should be a call to apr_ldap_url_parse_ext()***
    if( rc != APR_SUCCESS ) {
        return rc;
    }

    if ((*ludpp)->lud_scope == -1) {
        (*ludpp)->lud_scope = LDAP_SCOPE_BASE;
    }

    if ((*ludpp)->lud_host != NULL && *(*ludpp)->lud_host == '\0') {
        (*ludpp)->lud_host = NULL;
    }

    return rc;

}


Line #584 should be a call to apr_ldap_url_parse_ext() rather than
ldap_url_parse_ext() correct?  Otherwise it conflicts with the native
prototype.

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com 

>>> Graham Leggett <minfrin@sharp.fm> Tuesday, August 03, 2004 5:05:31
PM >>>
Graham Leggett wrote:

> I'm busy giving apr_ldap_url the full APR treatment - allocate memory

> from pools, etc. There'll be no need to use the native ldap URL parse

> routines any more.

It's in and compiles against openldap v2. Please can someone check that

the Windows and Netware builds also work.

Regards,
Graham
--


Mime
View raw message