apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: apr win32 bug [PATCH]
Date Mon, 02 Aug 2004 01:07:23 GMT
Although I agree, with your patch in spirit, if apr_thread_join is never
called, your patch -can- leak handles like a sieve :(

Did we ever define that apr_thread_create() must be partnered with
an apr_thread_join?  If not, it seems we need a clever way to mark
the apr_thread_t HANDLE member as destroyed, and allow the
apr_thread_join to simply return immediately.

Bill

At 04:52 PM 7/31/2004, Max Khon wrote:
>Hi!
>
>apr_thread_join for win32 is implemented incorrectly:
>thread handle is destroyed too early (in apr_thread_exit).
>If apr_thread_exit() is called before apr_thread_join() and
>new object is created (thread handle is reused) before
>calling apr_thread_join(), apr_thread_join() will possibly wait
>on invalid handle.
>
>Patch is attached.
>
>/fjoe



Mime
View raw message