apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Stoddard <b...@wstoddard.com>
Subject Re: [PATCH] WIN32 Fix apr_stat obtaing protection info
Date Fri, 27 Aug 2004 20:01:49 GMT
Mladen Turk wrote:

> Hi,
> 
> apr_stat fails obtaining protection cause APR_READCONTROL flag set
> on apr_file_open inside apr_stat is never used.
> The READ_CONTROL is needed cause GetSecurityInfo returns
> Access is denied otherwise.
> 
> Tested both on files and dirs, and... one break less in testall :)
> 
> 
> Index: open.c
> ===================================================================
> RCS file: /home/cvspublic/apr/file_io/win32/open.c,v
> retrieving revision 1.121
> diff -u -r1.121 open.c
> --- open.c    13 Feb 2004 09:38:27 -0000    1.121
> +++ open.c    27 Aug 2004 19:25:47 -0000
> @@ -324,6 +324,8 @@
>          else {
>              return APR_EACCES;
>          }
> +        if (flag & APR_READCONTROL)
> +            oflags |= READ_CONTROL;
>      }
> 
>      if (flag & APR_XTHREAD) {
> 
> 
> Regards,
> MT.
> 

Just out of curiosity, does this change affect performance serving static files in any measureable
way?

Bill

Mime
View raw message