apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: RC6 take 2
Date Thu, 26 Aug 2004 16:49:24 GMT
Justin Erenkrantz wrote:
> 
>> Well, I should run the test with verbose:
>> Listed only the one with verbose messages
>> (both SUCCESS and FAIL).
> 
> 
> I hate to ask this: but have these tests ever worked?  I guess it's 
> sucky that some tests fail on Win32, but if they never worked, I don't 
> consider it a showstopper.  (There just aren't enough Win32 developers 
> to look at it?)
> 

Well, I'm not an apr commiter.
In about 10 patches I propose eventually
one or two get even looked in :(.

Here is the patch for makefile that at least makes testall not hanging.
(There was no readchild.exe to read the pipes).
So, you may commit that, and one error less :).

Index: Makefile.win
===================================================================
RCS file: /home/cvspublic/apr/test/Makefile.win,v
retrieving revision 1.22
diff -u -r1.22 Makefile.win
--- Makefile.win	26 Jul 2004 15:21:59 -0000	1.22
+++ Makefile.win	26 Aug 2004 16:34:40 -0000
@@ -6,7 +6,8 @@
  	sendfile.exe \
  	proc_child.exe \
          tryread.exe \
-	occhild.exe\
+	occhild.exe \
+	readchild.exe \
  	sockchild.exe \
  	testlockperf.exe \
  	testshmproducer.exe \
@@ -39,6 +40,9 @@

  occhild.exe: occhild.obj $(LOCAL_LIBS)
  	$(LINK) occhild.obj $(LOCAL_LIBS) $(ALL_LIBS)
+
+readchild.exe: readchild.obj $(LOCAL_LIBS)
+	$(LINK) readchild.obj $(LOCAL_LIBS) $(ALL_LIBS)

  proc_child.exe: proc_child.obj $(LOCAL_LIBS)
  	$(LINK) /debug /subsystem:console /machine:I386 \


> We *need* to get 1.0 out the door.  We've done *SIX* (to paraphrase our 
> British developers, "bloody fricking *SIX*") release candidates for 1.0 
> so far.  This is insane!  I don't blame David if he loses his sanity 
> about now.
> 
> 1.0 does *not* need to perfect.  At some point, we need to ship.  -- justin
> 
> 

Sure.
But please don't shoot the messanger :).

Regards,
MT.


Mime
View raw message