From dev-return-12444-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Jul 28 21:21:48 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 56698 invoked from network); 28 Jul 2004 21:21:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 28 Jul 2004 21:21:47 -0000 Received: (qmail 91695 invoked by uid 500); 28 Jul 2004 21:21:40 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 91459 invoked by uid 500); 28 Jul 2004 21:21:39 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 91432 invoked by uid 99); 28 Jul 2004 21:21:38 -0000 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=UPPERCASE_25_50 X-Spam-Check-By: apache.org X-pair-Authenticated: 198.145.31.2 Message-ID: <410818B8.8020400@electricjellyfish.net> Date: Wed, 28 Jul 2004 14:20:56 -0700 From: Garrett Rooney User-Agent: Mozilla Thunderbird 0.7.1 (Macintosh/20040626) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "William A. Rowe, Jr." CC: dev@apr.apache.org, dev@httpd.apache.org Subject: Re: using APR_STATUS_IS_SUCCESS References: <4107F3A2.40504@modperlcookbook.org> <41080131.1040008@electricjellyfish.net> <6.1.2.0.2.20040728145325.05a69590@pop3.rowe-clan.net> In-Reply-To: <6.1.2.0.2.20040728145325.05a69590@pop3.rowe-clan.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N William A. Rowe, Jr. wrote: > The initial thought was you might have LDAP success, OS status success, > and possibly multiple return codes that were considered successes. > > Nothing was ever done with this. What about the win32 definition of the macro: #define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \ || (s) == APR_OS_START_SYSERR + ERROR_SUCCESS) If you just compare against APR_SUCCESS won't you miss the ERROR_SUCCESS part there? -garrett