From dev-return-12442-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Jul 28 20:48:03 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 42699 invoked from network); 28 Jul 2004 20:48:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 28 Jul 2004 20:48:03 -0000 Received: (qmail 4622 invoked by uid 500); 28 Jul 2004 20:47:54 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 4475 invoked by uid 500); 28 Jul 2004 20:47:53 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 4448 invoked by uid 99); 28 Jul 2004 20:47:53 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Message-ID: <410810D8.6080807@modperlcookbook.org> Date: Wed, 28 Jul 2004 13:47:20 -0700 From: Geoffrey Young User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040124 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org, dev@apr.apache.org Subject: Re: using APR_STATUS_IS_SUCCESS References: <4107F3A2.40504@modperlcookbook.org> <41080131.1040008@electricjellyfish.net> In-Reply-To: <41080131.1040008@electricjellyfish.net> X-Enigmail-Version: 0.83.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 28 Jul 2004 20:47:43.0957 (UTC) FILETIME=[21AD0850:01C474E4] X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N cross-posted to dev@apr Garrett Rooney wrote: > Geoffrey Young wrote: > >> hi all >> >> I was just in garrett's APR talk here at oscon and he was mentioning the >> APR_STATUS_IS_SUCCESS macro, which I found interesting since httpd >> only uses >> it in a few places, opting for a direct comparison to APR_SUCCESS >> instead. >> >> should we move to APR_STATUS_IS_SUCCESS in all places? can someone who >> groks the nuances of the macro add some insight here? > > > This is actually something I was wondering about as I wrote the > presentation. Neither Apache or Subversion use APR_STATUS_IS_SUCCESS > everywhere, but I wonder if we should, since if you look at the > definition of the macro there are cases when it's more than just (s) == > APR_SUCCESS. just another note, I grep'd the code for "rc == APR_SUCCESS" and it looks like not even APR is using the macro everywhere... --Geoff