apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: cvs commit: apr/network_io/win32 sendrecv.c sockets.c
Date Thu, 22 Jul 2004 11:30:09 GMT
On 22 Jul 2004 01:48:35 -0000, stoddard@apache.org <stoddard@apache.org> wrote:
> stoddard    2004/07/21 18:48:35
> 
>   Modified:    .        CHANGES

===================================================================
>   RCS file: /home/cvs/apr/CHANGES,v
>   retrieving revision 1.483
>   retrieving revision 1.484
>   diff -u -r1.483 -r1.484
>   --- CHANGES   20 Jul 2004 03:31:57 -0000      1.483
>   +++ CHANGES   22 Jul 2004 01:48:34 -0000      1.484
>   @@ -1,4 +1,6 @@
>    Changes for APR 1.1 [Deferring these features when 1.0 is rolled out.]
>   +  *) Win32: Fix bug in apr_socket_sendfile that interferred with
>   +     Win32 LSPs. PR 23982 [Jan Bilek, Bill Stoddard]

Bill, this probably sounds like a nit (because it is), but there is a
blank line after "Changes for <release>".  For some of us simple minds
(okay, just me), that looks really ugly in the context of entire file,
which has a blank line between every element.

On a slightly more interesting note, I committed something to APR HEAD
a few days ago and was faced with the question "darn, under what APR
release number do I put the CHANGES entry?"...  I put it under 1.0,
and if some subsequent 1.0 tarball doesn't include it I guess we need
a new entry for 1.0.1.  Does anybody know the right answer?

Mime
View raw message