apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] KQueue AND sys_epoll Support for apr_pollset
Date Tue, 06 Jul 2004 03:40:49 GMT
--On Tuesday, June 15, 2004 8:41 AM -0700 Paul Querna <chip@force-elite.com> 
wrote:

>> On Mon, 2004-06-07 at 21:21 +0100, Joe Orton wrote:
>> Ah, also pollset_create will need to register a cleanup now there is
>> something to clean up now I notice...
>
> Updated Patch w/ pool cleanups attached.

The cleanup syntax wasn't quite right - so I tweaked it to fit our convention 
- i.e. use apr_pool_cleanup_run so that when apr_pollset_destroy is explicitly 
called, we don't run our cleanup twice.  Regardless, I just checked this in. 
Looks fine on Darwin and FreeBSD 5.x (and Solaris which doesn't have KQueue or 
epoll).

Thanks!

David: This change probably shouldn't make it into 1.0, so we'll have to 
adjust CHANGES once you lay down the final tag.  -- justin

Mime
View raw message