apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: apr/threadproc/netware proc.c
Date Fri, 09 Jul 2004 21:02:35 GMT
On Fri, Jul 09, 2004 at 08:29:05PM -0000, clar@apache.org wrote:
>   --- proc.c	14 Jun 2004 17:26:19 -0000	1.29
>   +++ proc.c	9 Jul 2004 20:29:05 -0000	1.30
>   @@ -179,7 +179,7 @@
>    
>    APR_DECLARE(apr_status_t) apr_procattr_detach_set(apr_procattr_t *attr, apr_int32_t
detach) 
>    {
>   -    attr->detached = detach;
>   +    attr->detached = (detach & 1);
>        return APR_SUCCESS;

This implements a different interface to that described in the header,
so -1 again.  The point of the discussion we had is that you have to do
the messy work *inside mod_cgi*, because that's where the binary compat
requirement is.  So mod_cgi should be doing e.g.:

  apr_procattr_detach_set(procattr, e_info->detached & 1)
  apr_procattr_addrspace_set(procattr, e_info->detached & 2)

and it needs to be documented in mod_cgi.h that the detached field is
used as a bitfield like this in the 2.0 branch.  For mod_cgi in HEAD it
needn't be weird of course, the addrspace field could be left in there.

joe


Mime
View raw message