apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig Rodrigues <rodr...@crodrigues.org>
Subject Re: testall.c is in the attic?
Date Thu, 08 Jul 2004 21:46:40 GMT
On Fri, Jul 02, 2004 at 11:29:43AM -0400, Ed Holyat wrote:
> It really doesn't matter, it is still looking for testall.obj.  the dsw uses
> "nmake /f Makefile.win all"

Hi,

You are definitely right.  The Makefile.win is definitely broken.
Looks like nobody has been compilingn the APR tests with VC++ for a while.

Can you try the following patch?


Index: Makefile.win
===================================================================
RCS file: /home/cvspublic/apr/test/Makefile.win,v
retrieving revision 1.21
diff -u -r1.21 Makefile.win
--- Makefile.win	9 Apr 2004 02:03:12 -0000	1.21
+++ Makefile.win	8 Jul 2004 21:40:01 -0000
@@ -78,7 +78,7 @@
 testmutexscope.exe: testmutexscope.obj $(LOCAL_LIBS)
 	$(LINK) testmutexscope.obj $(LOCAL_LIBS) $(ALL_LIBS)
 
-TESTS = testall.obj testtime.obj teststr.obj testvsn.obj testipsub.obj \
+TESTS = abts.obj testtime.obj teststr.obj testvsn.obj testipsub.obj \
 	testmmap.obj testud.obj testtable.obj testsleep.obj testpools.obj \
 	testfmt.obj testfile.obj testdir.obj testfileinfo.obj testrand.obj \
 	testdso.obj testoc.obj testdup.obj testsockets.obj testproc.obj \
@@ -87,10 +87,10 @@
 	testenv.obj testprocmutex.obj testrand2.obj testfnmatch.obj \
         testatomic.obj testflock.obj testshm.obj testsock.obj \
         testglobalmutex.obj teststrnatcmp.obj testfilecopy.obj \
-        testtemp.obj testlfs.obj
+        testtemp.obj testlfs.obj testutil.obj
 
-testall.exe: $(TESTS) CuTest.obj $(LOCAL_LIBS)
-	$(LINK) /debug /subsystem:console /machine:I386 $(TESTS) CuTest.obj \
+testall.exe: $(TESTS) $(LOCAL_LIBS)
+	$(LINK) /debug /subsystem:console /machine:I386 /out:$@ $(TESTS) \
 		$(LOCAL_LIBS) $(ALL_LIBS)
 
 
Index: teststr.c
===================================================================
RCS file: /home/cvspublic/apr/test/teststr.c,v
retrieving revision 1.25
diff -u -r1.25 teststr.c
--- teststr.c	30 Jun 2004 11:10:24 -0000	1.25
+++ teststr.c	8 Jul 2004 21:29:29 -0000
@@ -20,6 +20,10 @@
 #include <stdio.h>
 #include <string.h>
 
+#if APR_HAVE_LIMITS_H
+#include <limits.h>
+#endif
+
 #include "apr_general.h"
 #include "apr_strings.h"
 #include "apr_errno.h"


--
Craig Rodrigues        
http://crodrigues.org
rodrigc@crodrigues.org

Mime
View raw message