apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] Stop installing apr-config, and give clients an APR_FIND_APR that works with apr-1-config.
Date Fri, 16 Jul 2004 06:06:03 GMT
--On Friday, July 16, 2004 12:37 AM +0100 Max Bowsher <maxb@ukf.net> wrote:

> Regarding subversion: will probably want to absorb the new find_apr.m4, in
> order to permit experimental building against apr-1.0.0, but are locked into
> apr-0 for the 1.x release cycle officially by ABI guarantees, AFAIK.

FWIW, I believe that's incorrect: Subversion supports APR 1.0, too.  The 
Subversion ABI requirements don't necessarily extend to its APR exposed 
interfaces - although this has been a point of contention raised by Greg 
Hudson over on dev@svn.  So, SVN should get a new drop of find_ap{ru}.m4 and 
either not specify the version to bundle against or pass [1 0].

Yet, that's a big problem with your patch: you are now making all of the 
arguments mandatory to APR_FIND_APR - the builddir and implicit-install-check 
are not supposed to be mandatory - APR_FIND_APR(apr) is supposed to be all 
that is required.  So, I guess I'd rather see $4 default to [1 0] instead of 
erroring out - or only error out if we don't have the bundled source.  This 
goes back to the idea that the bundled source is 'always' correct.  -- justin

View raw message