apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Max Bowsher" <m...@ukf.net>
Subject Re: [PATCH] update find_ap{ru}.m4 for ap{ru}-1-config was Re: 1.0.0 RC4 (apr-config -> apr-1-config)
Date Thu, 15 Jul 2004 09:38:06 GMT
Justin Erenkrantz wrote:
> Tweak find_apr.m4 to look for apr-1-config then look for apr-config.  None
of
> these projects you mention need any changes other than a new
find_ap{ru}.m4.
> They all use $apr_config *after* find_ap{ru}.m4 runs.  That's why we
designed
> find_ap{ru}.m4 in the way we did - so that changes like this are extremely
> non-intrusive.
>
> Update those find_ap{ru}.m4 in projects that have it, then you're done.
> Completely untested patch attached.  I hope my mailer doesn't do anything
> stupid with it, but you should get the gist of it.  -- justin

Thanks for the patch, but unfortunately, it has some flaws:

1) It doesn't update configure.in / Makefile.in to name apr-config
apr-MAJOR-config in the build directory.

2) It assumes bundled apr will be apr-1. We want to make find_apr.m4
independent of apr version, so that in the future, it could be installed
into a system aclocal directory (thanks to noahmcit on #apr for pointing
this out).

3) It only implements "accept apr-0 or apr-1", but unless projects do extra
compatibility work, and make sure to *never* expose the apr ABI in their own
ABI, they will want "accept apr-0 only" or "accept apr-1 only".


I'll be writing up an implementation proposal for a set of changes
addressing this, and posting it to this list shortly.

Max.


Mime
View raw message