Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <6.1.0.6.2.20040623134034.089a4ec0@pop3.rowe-clan.net>
Date: Wed, 23 Jun 2004 13:41:28 -0500
To: dev@apr.apache.org
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: cvs commit: apr-util/xlate xlate.c
In-Reply-To: <20040623180002.7527.qmail@minotaur.apache.org>
References: <20040623180002.7527.qmail@minotaur.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

Do we know what broke here from history?  Was the pool arg added
(breaking binary compat) in the 0.9 tree, or was this backing out a
bugged change?

At 01:00 PM 6/23/2004, stoddard@apache.org wrote:
>stoddard    2004/06/23 11:00:02
>
>  Modified:    xlate    Tag: APU_0_9_BRANCH xlate.c
>  Log:
>  Fix build breakage on APR_HAVE_APR_ICONV path
>  
>  Revision  Changes    Path
>  No                   revision
>  No                   revision
>  1.17.2.3  +3 -3      apr-util/xlate/xlate.c
>  
>  Index: xlate.c
>  ===================================================================
>  RCS file: /home/cvs/apr-util/xlate/xlate.c,v
>  retrieving revision 1.17.2.2
>  retrieving revision 1.17.2.3
>  diff -u -r1.17.2.2 -r1.17.2.3
>  --- xlate.c   27 May 2004 21:55:02 -0000      1.17.2.2
>  +++ xlate.c   23 Jun 2004 18:00:02 -0000      1.17.2.3
>  @@ -178,9 +178,9 @@
>       else {
>           /* reset the iconv descriptor, since it's now in an undefined
>            * state. */
>  -        apr_iconv_close(convset->ich);
>  -        convset->ich = apr_iconv_open(convset->topage, convset->frompage);
>  -    }
>  +        apr_iconv_close(convset->ich, convset->pool);
>  +        rv = apr_iconv_open(convset->topage, convset->frompage, convset->pool, &convset->ich);
>  +     }
>   }
>   #endif /* APU_HAVE_APR_ICONV */
>   
>  
>  
>