Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 33577 invoked from network); 6 Jun 2004 06:23:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 6 Jun 2004 06:23:32 -0000 Received: (qmail 20172 invoked by uid 500); 6 Jun 2004 06:23:34 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 20141 invoked by uid 500); 6 Jun 2004 06:23:34 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 20120 invoked by uid 99); 6 Jun 2004 06:23:33 -0000 Date: Sat, 05 Jun 2004 23:23:17 -0700 From: Justin Erenkrantz To: Paul Querna , dev@apr.apache.org Subject: Re: [PATCH] KQueue AND sys_epoll Support for apr_pollset Message-ID: <121A4593423DA887E198A60A@[10.0.1.7]> In-Reply-To: <1086502178.13776.32.camel@localhost> References: <1086502102.13777.30.camel@localhost> <1086502178.13776.32.camel@localhost> X-Mailer: Mulberry/3.1.5 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable version=3.0.0-r10630 X-Spam-Checker-Version: SpamAssassin 3.0.0-r10630 (2004-05-13) on scotch.ics.uci.edu X-Virus-Scanned: clamd / ClamAV version 0.70, clamav-milter version 0.70j X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N --On Saturday, June 5, 2004 11:09 PM -0700 Paul Querna wrote: > + // APR_POLLNVAL is not handled by epoll? > + // invalid FDs are automagicaly removed. You can't use C99 comments as a bunch of our supported compilers choke on them. Please use /* */ instead. Other than that, your patch looks sane. +1 on the concept... -- justin