From dev-return-12135-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon Jun 28 21:52:42 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 64234 invoked from network); 28 Jun 2004 21:52:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 28 Jun 2004 21:52:42 -0000 Received: (qmail 1430 invoked by uid 500); 28 Jun 2004 21:52:54 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 1273 invoked by uid 500); 28 Jun 2004 21:52:52 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 1096 invoked by uid 99); 28 Jun 2004 21:52:50 -0000 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST X-Spam-Check-By: apache.org Date: Mon, 28 Jun 2004 17:52:21 -0400 From: Dmitri Tikhonov To: dev@apr.apache.org Subject: 62 seconds in a minute? :) Message-ID: <20040628215220.GG17363@netilla.com> Mail-Followup-To: dev@apr.apache.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="L1c6L/cjZjI9d0Eq" Content-Disposition: inline User-Agent: Mutt/1.5.6i X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N --L1c6L/cjZjI9d0Eq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, apr-util/misc/apr_date.c contains this piece of code: if ((ds.tm_hour > 23) || (ds.tm_min > 59) || (ds.tm_sec > 61))=20 return APR_DATE_BAD; I am not sure I understand why we allow number of seconds in time string to be 60 or 61. Apparently, this has been there since the very first revision of the file. http://cvs.apache.org/viewcvs.cgi/apr-util/misc/apr_date.c?rev=3D1.17&view= =3Dmarkup - Dmitri. --L1c6L/cjZjI9d0Eq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQFA4JMUEVjlCyBA0pIRAnEQAJsFeJCEHcO4Qc3Jb2zGCjCbyxKCAgCfT8Fb 55s1iKx+mNOfg0fbjnTXu98= =xx/G -----END PGP SIGNATURE----- --L1c6L/cjZjI9d0Eq--