apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: apr/include apr_thread_proc.h
Date Fri, 11 Jun 2004 20:47:42 GMT
clar@apache.org wrote:
> clar        2004/06/11 13:13:19
> 
>   Modified:    include  apr_thread_proc.h
>   Log:
>   Added NetWare specific option in apr_cmdtype_e to start program in a separate address
space for cmdtype field in apr_procattr_t struct
>   
>   Revision  Changes    Path
>   1.106     +7 -4      apr/include/apr_thread_proc.h
>   
>   Index: apr_thread_proc.h
>   ===================================================================
>   RCS file: /home/cvs/apr/include/apr_thread_proc.h,v
>   retrieving revision 1.105
>   retrieving revision 1.106
>   diff -u -r1.105 -r1.106
>   --- apr_thread_proc.h	10 Jun 2004 10:57:24 -0000	1.105
>   +++ apr_thread_proc.h	11 Jun 2004 20:13:19 -0000	1.106
>   @@ -42,10 +42,13 @@
>     */
>    
>    typedef enum {
>   -    APR_SHELLCMD,       /**< use the shell to invoke the program */
>   -    APR_PROGRAM,        /**< invoke the program directly, no copied env */
>   -    APR_PROGRAM_ENV,    /**< invoke the program, replicating our environment */
>   -    APR_PROGRAM_PATH    /**< find program on PATH, use our environment */
>   +#ifdef NETWARE
>   +    APR_PROGRAM_ADDRSPACE,  /**< invoke the program in its own address space */
>   +#endif

why wouldn't that be a separate process attribute?  quite enough (too much?) 
characteristics specified via cmdtype attribute already

consider:

apr_procattr_shared_as_set(apr_procattr_t *attr, int allow_shared_as);

if allow_shared_as is non-zero, then implementation can possibly run the 
command in same address space as parent (everywhere but NetWare would have that 
a no-op)...

Mime
View raw message