apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: apr-util/xml apr_xml.c
Date Tue, 22 Jun 2004 21:45:59 GMT
[resend in case it gets through quicker]

On Tue, Jun 22, 2004 at 10:42:23AM -0000, jfclere@apache.org wrote:
>   --- apr_xml.c	14 Jun 2004 15:13:14 -0000	1.30
>   +++ apr_xml.c	22 Jun 2004 10:42:23 -0000	1.31
>   @@ -30,17 +30,23 @@
>    #include "expat.h"
>    #endif
>    
>   +#include "ascii.h"
>   +
>    #define DEBUG_CR "\r\n"

ascii.h is an internal expat header, this broke the Unix build with an
external expat library.

Why take a convset if this can only convert to EBCDIC? You know that the
tree is in UTF-8 so there is no other variable for the caller to
control.

Why does the DOM tree need to be converted into the local charset
in-place anyway?

#if APR_CHARSET_EBCDIC
/**
 * Convert parsed tree in EBCDIC 
 * @param p The pool to allocate out of
 * @param pdoc The apr_xml_doc to convert.
 * @param xlate The translation handle to use.
 * @return Any errors found during conversion.
 */
APU_DECLARE(apr_status_t) apr_xml_parser_convert_doc(apr_pool_t *p,
                                                     apr_xml_doc *pdoc,
                                                     apr_xlate_t *convset);
#endif


Mime
View raw message