apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <...@manyfish.co.uk>
Subject Re: [PATCH] KQueue AND sys_epoll Support for apr_pollset
Date Mon, 07 Jun 2004 20:21:42 GMT
On Sun, Jun 06, 2004 at 02:25:15PM -0700, Justin Erenkrantz wrote:
> --On Sunday, June 6, 2004 1:02 AM -0700 Paul Querna <chip@force-elite.com> 
> wrote:
> 
> >>Other than that, your patch looks sane.  +1 on the concept...  -- justin
> >
> >sweet.
> 
> Just tested on FreeBSD 5.2.1 - looks fine.  +1.  I'll give others a
> day or so to look at it - if no one complains, I'll commit it.
> 
> FWIW, I fixed up a bunch of style nits - see attached.  -- justin

Excellent... Paul, is there a reason you test for kevent() in configure
rather than kqueue()? (if the latter is sufficient, simply adding kqueue
to an AC_CHECK_FUNCS somewhere is easier)

Here's another iteration with proper configure code for safe epoll
detection and more style nit fixes.

Ah, also pollset_create will need to register a cleanup now there is
something to clean up now I notice...

joe

Mime
View raw message