Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 86889 invoked from network); 22 May 2004 05:08:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 22 May 2004 05:08:31 -0000 Received: (qmail 67750 invoked by uid 500); 22 May 2004 05:08:52 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 67676 invoked by uid 500); 22 May 2004 05:08:52 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 67661 invoked by uid 98); 22 May 2004 05:08:52 -0000 X-Qmail-Scanner-Mail-From: wrowe@rowe-clan.net via hermes.apache.org X-Qmail-Scanner: 1.20 (Clear:RC:0(207.155.248.7):. Processed in 0.019767 secs) Errors-To: Message-Id: <6.1.0.6.2.20040522000342.02d88ec0@pop3.rowe-clan.net> X-Sender: wrowe%rowe-clan.net@pop3.rowe-clan.net X-Mailer: QUALCOMM Windows Eudora Version 6.1.0.6 Date: Sat, 22 May 2004 00:04:39 -0500 To: Stas Bekman From: "William A. Rowe, Jr." Subject: Re: enum and defines naming Cc: APR Development In-Reply-To: <40AEA6AC.40005@stason.org> References: <40AEA6AC.40005@stason.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Spam-Rating: hermes.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N At 08:02 PM 5/21/2004, Stas Bekman wrote: >Before apr 1.0 is cast in stone any chance public enums and defines will get sensible names? >It all looks nice in the declaration but in the code, one needs to scratch the head to figure out what APR_REG means. Why not have /^APR_FILETYPE_/ prefix? APR_FILETYPE_REG requires no head scratching when reading the code and won't collide with some other enum with a totally different functionality. +1 >Same goes for defines, for example: >There are all related to files, why pollute the namespace with such short names and not fix them to have a sensible prefix similar to above suggestion? /^APR_FILETYPE_/ as in APR_FILETYPE_UREAD. +1 again. This is why 1.0 isn''t ready just yet, IMHO :)