Return-Path: 
 <dev-return-11838-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 21821 invoked from network); 28 May 2004 14:09:38 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 28 May 2004 14:09:38 -0000
Received: (qmail 10363 invoked by uid 500); 28 May 2004 14:09:43 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 10167 invoked by uid 500); 28 May 2004 14:09:41 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Subscribe: <mailto:dev-subscribe@apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 10085 invoked by uid 98); 28 May 2004 14:09:40 -0000
X-Qmail-Scanner-Mail-From: jfrederic.clere@fujitsu-siemens.com via
 hermes.apache.org
X-Qmail-Scanner: 1.20 (Clear:RC:0(217.115.66.9):. Processed in 0.13743 secs)
Message-ID: <40B748C7.8000308@fujitsu-siemens.com>
Date: Fri, 28 May 2004 16:12:23 +0200
From: jean-frederic clere <jfrederic.clere@fujitsu-siemens.com>
Reply-To: jfrederic.clere@fujitsu-siemens.com
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040517
X-Accept-Language: en, fr, de
MIME-Version: 1.0
To: Joe Orton <joe@manyfish.co.uk>, dev@apr.apache.org
Subject: Re: cvs commit: apr-util/xml apr_xml.c
References: <20040521071344.12295.qmail@minotaur.apache.org>
 <20040521085146.GA19706@manyfish.co.uk>
 <40ADFA95.1030400@fujitsu-siemens.com> <20040527185620.GB4612@manyfish.co.uk>
In-Reply-To: <20040527185620.GB4612@manyfish.co.uk>
X-Enigmail-Version: 0.84.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new
X-Spam-Rating: hermes.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Joe Orton wrote:
> On Fri, May 21, 2004 at 02:48:21PM +0200, jean-frederic clere wrote:
> 
>>Joe Orton wrote:
>>
>>>On Fri, May 21, 2004 at 07:13:44AM -0000, jfclere@apache.org wrote:
>>>
>>>
>>>>jfclere     2004/05/21 00:13:44
>>>>
>>>>Modified:    xml      apr_xml.c
>>>>Log:
>>>>Print "No parser." in errbuf when parser is NULL.
>>>
>>>
>>>Why? Passing a NULL parser argument to apr_xml_parser_geterror sounds
>>>like a good time to SIGSEGV.
>>
>>Before commiting it I have looked in apache-2.0/server/util_xml.c: there 
>>is a apr_xml_parser_geterror()...
> 
> 
> It's not valid (as far as I can see, needn't be valid) to pass a NULL
> parser argument to apr_xml_parser_geterror().  What bug are you seeing
> which prompted this change?

Sorry... If apr_xml_parser_create() returns NULL.

The bug only occurs in apr-util/test/testxml I will rollback the correction (in 
xml/apr_xml.c) and fix test/testxml.c.

That is the xml file that cores testxml:
+++
<?xml version='1.0' encoding='utf-8'
<tomcat-users>
   <role rolename="tomcat"/>
   <role rolename="role1"/>
   <user username="tomcat" password="tomcat" roles="tomcat"/>
   <user username="both" password="tomcat" roles="tomcat,role1"/>
   <user username="role1" password="tomcat" roles="role1"/>
</tomcat-users>
+++

> 
> joe
> 
>