Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 67208 invoked from network); 23 May 2004 22:54:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 23 May 2004 22:54:10 -0000 Received: (qmail 45346 invoked by uid 500); 23 May 2004 22:54:11 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 45271 invoked by uid 500); 23 May 2004 22:54:10 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 45232 invoked by uid 98); 23 May 2004 22:54:09 -0000 X-Qmail-Scanner-Mail-From: joe@manyfish.co.uk via hermes.apache.org X-Qmail-Scanner: 1.20 (Clear:RC:0(62.253.162.49):. Processed in 0.127177 secs) Date: Sun, 23 May 2004 23:53:59 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: cvs commit: apr/test testshm.c Message-ID: <20040523225359.GA24839@manyfish.co.uk> Mail-Followup-To: dev@apr.apache.org References: <20040515195150.26525.qmail@minotaur.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20040515195150.26525.qmail@minotaur.apache.org> User-Agent: Mutt/1.4.1i X-Spam-Rating: hermes.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Sat, May 15, 2004 at 07:51:50PM -0000, Ryan Bloom wrote: > rbb 2004/05/15 12:51:50 > > Modified: test testshm.c > Log: > If we can't create the shared memory segment, don't try to keep going > through the test. Doing so causes a segfault to occur. Re-enable this > test. Oh, I hadn't realised that assumption had changed. Where are you going with this? Without the assumption that a failed test causes a longjmp out of the test function, the entire suite is unreliable, it will segfault in so many failure cases... joe