apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: cvs commit: apr-util/xml apr_xml.c
Date Fri, 28 May 2004 14:12:23 GMT
Joe Orton wrote:
> On Fri, May 21, 2004 at 02:48:21PM +0200, jean-frederic clere wrote:
> 
>>Joe Orton wrote:
>>
>>>On Fri, May 21, 2004 at 07:13:44AM -0000, jfclere@apache.org wrote:
>>>
>>>
>>>>jfclere     2004/05/21 00:13:44
>>>>
>>>>Modified:    xml      apr_xml.c
>>>>Log:
>>>>Print "No parser." in errbuf when parser is NULL.
>>>
>>>
>>>Why? Passing a NULL parser argument to apr_xml_parser_geterror sounds
>>>like a good time to SIGSEGV.
>>
>>Before commiting it I have looked in apache-2.0/server/util_xml.c: there 
>>is a apr_xml_parser_geterror()...
> 
> 
> It's not valid (as far as I can see, needn't be valid) to pass a NULL
> parser argument to apr_xml_parser_geterror().  What bug are you seeing
> which prompted this change?

Sorry... If apr_xml_parser_create() returns NULL.

The bug only occurs in apr-util/test/testxml I will rollback the correction (in 
xml/apr_xml.c) and fix test/testxml.c.

That is the xml file that cores testxml:
+++
<?xml version='1.0' encoding='utf-8'
<tomcat-users>
   <role rolename="tomcat"/>
   <role rolename="role1"/>
   <user username="tomcat" password="tomcat" roles="tomcat"/>
   <user username="both" password="tomcat" roles="tomcat,role1"/>
   <user username="role1" password="tomcat" roles="role1"/>
</tomcat-users>
+++

> 
> joe
> 
> 


Mime
View raw message