apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Amit Athavale <amit_athav...@persistent.co.in>
Subject Re: apr_shm_attach() and APR_EEXIST
Date Fri, 28 May 2004 12:09:49 GMT
Thanks for quick review.

Joe Orton wrote:

>On Fri, May 28, 2004 at 05:08:17PM +0530, Amit Athavale wrote:
>  
>
>>Here is initial patch:
>>
>>- only for unix, if this OK I will write for other platforms
>>- Tested on linux RH 8.0 and solaris 9
>>- New test case added in testshm.c
>>
>>Please review it so I can provide patch for other platforms ASAP.
>>    
>>
>
>Looks good, thanks a lot Amit... patch against APR HEAD would be
>preferred though.  There's no need for apr_shm_remove() to have an
>APR_ENOTIMPL case: the caller knows not to call this function for an
>anonymous segment.
>
So should APR_SUCCESS be return type by default?



Mime
View raw message