apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [PATCH] add apr_strtoff function (string to apr_off_t)
Date Sun, 23 May 2004 21:17:50 GMT
* Joe Orton <joe@manyfish.co.uk> wrote:

> On Sun, May 23, 2004 at 10:48:51PM +0200, André Malo wrote:
> > The attachted patch adds a strtoff (maybe bad named) function, which
> > converts a numerical string to an apr_off_t value. (Win32 and Netware
> > untested).
> 
> apr_status_t apr_strtoff(apr_off_t *offset, const char *buf, char **end, int
> base){
>   errno = 0;
>   *offset = APR_STRTOFF(buf, end, base);
>   return errno ? errno : 0;
> } 
> 

I'm not sure about the policy, but sounds fine to me... except that I'm
wondering if it shouln't be

return APR_FROM_OS_ERROR(errno);

then.

nd
-- 
Winnetous Erbe: <http://pub.perlig.de/books.html#apache2>

Mime
View raw message