Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <20040417164851.52475.qmail@web25202.mail.ukl.yahoo.com>
Date: Sat, 17 Apr 2004 17:48:51 +0100 (BST)
From: =?iso-8859-1?q?Ami=20Ganguli?= <hse_ami@yahoo.co.uk>
Subject: Re: precalculating hash values for apr_hash_t
To: rbb@rkbloom.net
Cc: dev@apr.apache.org
In-Reply-To: <1082222101.408166157c8bf@webmail.mydomain.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

 --- rbb@rkbloom.net wrote: > 
> How are you computing your pre-computed hash values?
>  Did you copy the hashing
> algorithm from APR's find_entry?  

Yup.

> My biggest concern with this function is that the
> caller's hash function must
> agree with APR's hash function or the hash table
> won't work.  

Good point.

> A better approach to this, IMHO, is to create a new
> apr_hash_make function that
> allows a user to pass in a hash function.  This way,
> your program could
> pre-compute and cache the hash values.  When
> apr_hash_set or apr_hash_get are
> called, they will call your hashing function, which
> could then retrieve the
> correct value from the hash.

In fact, that would work quite nicely.  I'll work up a
patch.

... Ami.


____________________________________________________________
Yahoo! Messenger - Communicate instantly..."Ping" 
your friends today! Download Messenger Now 
http://uk.messenger.yahoo.com/download/index.html