From dev-return-11547-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Sun Apr 18 17:09:17 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 31765 invoked from network); 18 Apr 2004 17:09:17 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 18 Apr 2004 17:09:17 -0000 Received: (qmail 89284 invoked by uid 500); 18 Apr 2004 17:09:09 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 89250 invoked by uid 500); 18 Apr 2004 17:09:07 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 89236 invoked from network); 18 Apr 2004 17:09:07 -0000 Message-ID: <1082310481.4082bf5189e5e@webmail.mydomain.com> Date: Sun, 18 Apr 2004 10:48:01 -0700 From: rbb@rkbloom.net To: =?iso-8859-1?b?QW5kcuk=?= Malo Cc: dev@apr.apache.org MIME-Version: 1.0 User-Agent: Internet Messaging Program (IMP) 3.1 X-Originating-IP: 24.211.145.52 X-SA-Exim-Mail-From: rbb@rkbloom.net Subject: Re: cvs commit: apr/test testhash.c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on calcium.dnsix.com X-Spam-Level: ** X-Spam-Status: No, hits=2.9 required=10.0 tests=NO_REAL_NAME, RCVD_IN_DYNABLOCK,RCVD_IN_SORBS autolearn=no version=2.63 X-Spam-Report: * 0.3 NO_REAL_NAME From: does not include a real name * 2.5 RCVD_IN_DYNABLOCK RBL: Sent directly from dynamic IP address * [24.211.145.52 listed in dnsbl.sorbs.net] * 0.1 RCVD_IN_SORBS RBL: SORBS: sender is listed in SORBS * [24.211.145.52 listed in dnsbl.sorbs.net] X-SA-Exim-Version: 3.1 (built Thu Oct 23 13:26:47 PDT 2003) X-SA-Exim-Scanned: Yes X-uvscan-result: clean (1BFFn2-0000a0-A1) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I fixed this. I thought I had re-compiled after my changes, but I must have just been in the test directory when I did it. Ryan Quoting André Malo : > * rbb@apache.org wrote: > > > +APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > > + apr_hashfunc_t > hash_func) > > +{ > > + ht = apr_hash_make(p); > > + ht->hash_func = hash_func; > > return ht; > > } > > > > I've thought there were a rule to check in only stuff that compiles... > > Index: apr_hash.c > =================================================================== > RCS file: /home/cvspublic/apr/tables/apr_hash.c,v > retrieving revision 1.37 > diff -u -r1.37 apr_hash.c > --- apr_hash.c 18 Apr 2004 12:12:49 -0000 1.37 > +++ apr_hash.c 18 Apr 2004 16:57:17 -0000 > @@ -102,7 +102,7 @@ > APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool, > apr_hashfunc_t hash_func) > { > - ht = apr_hash_make(p); > + apr_hash_t *ht = apr_hash_make(pool); > ht->hash_func = hash_func; > return ht; > } > > nd > -- > "Solides und umfangreiches Buch" > -- aus einer Rezension > > >