apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@rkbloom.net>
Subject Re: [PATCH] apr_arch_internal_time.h patch to fix prototype
Date Thu, 29 Apr 2004 18:38:30 GMT

No, neither should be exposed, but Unix (as a general rule, some
variants have solved this, most haven't) doesn't let us have that fine
grain-ed resolution, so the unix one is exposed.

Ryan

On Thu, 29 Apr 2004, Brad Nicholes wrote:

>    If we add APR_DECLARE() to the prototype, it will cause this function
> to be included in the export list.  Since this is a NetWare specific API
> similar to the Unix specific API (apr_unix_setup_time()), I'm not sure
> that we want to expose this function outside of APR.  If applications
> writers call either of these functions, they cease to be platform
> independent.  Is there a reason why either of these functions should be
> exposed outside of APR?
>
> Brad
>
> Brad Nicholes
> Senior Software Engineer
> Novell, Inc., the leading provider of Net business solutions
> http://www.novell.com
>
> >>> Guenter Knauf <eflash@gmx.net> Thursday, April 29, 2004 10:30:21 AM
> >>>
> found that the prototype for apr_netware_setup_time() doesnt match with
> the function (see apr/time/unix/time.c line 271);
>
> --- apr_arch_internal_time.h.orig	Fri Feb 13 12:12:36 2004
> +++ apr_arch_internal_time.h	Tue Apr 27 21:17:34 2004
> @@ -20,6 +20,6 @@
>
>  #define TZONE           (*___timezone())
>
> -void apr_netware_setup_time(void);
> +APR_DECLARE(void) apr_netware_setup_time(void);
>
>  #endif  /* TIME_INTERNAL_H */
>
>
> Guenter.
>
>


Mime
View raw message