apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: cvs commit: apr/test testhash.c
Date Sun, 18 Apr 2004 17:44:16 GMT
* rbb@rkbloom.net wrote:

> Quoting André Malo <nd@perlig.de>:
> 
> > * André Malo <nd@perlig.de> wrote:
> > 
> > >  APR_DECLARE(apr_hash_t *) apr_hash_make_custom(apr_pool_t *pool,
> > >                                                 apr_hashfunc_t
> > >                                                 hash_func)
> > 
> > Additionally hash_func should be a pointer (also in declaration in in the
> > hash
> > struct), shouldn't it?
> 
> It is a pointer.  Look at the definition:
> 
> typedef unsigned int (*apr_hashfunc_t)(const char *key, apr_ssize_t *klen);

oh well. Though I don't find that pointer hiding not very intuitive (you've
just seen the problem live ;-).

typedef unsigned int apr_hashfunc_t(const char *key, apr_ssize_t *klen);

would be better readable (to me).

nd
-- 
Winnetous Erbe: <http://pub.perlig.de/books.html#apache2>

Mime
View raw message