apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ami Ganguli <hse_...@yahoo.co.uk>
Subject Re: [PATCH] RFC: allow custom hash functions
Date Sat, 17 Apr 2004 20:55:55 GMT
Thanks for the quick review.

 --- rbb@rkbloom.net wrote: > 
> ->hash_func should always have a
> value, if the hash_table isn't creted with
> apr_hash_make_custom(), then
> apr_hash_make() should set it to a default hash
> function, which is the current
> hash algorithm. 

That was my original plan.  Small problem... the
APR_HASH_KEY_STRING case requires that we find the key
length.  Having the hash in-line gives us this for
free.  Traversing the string again is extra overhead,
while having the hash function return the length
seemed really ugly.

... Ami.

Yahoo! Messenger - Communicate instantly..."Ping" 
your friends today! Download Messenger Now 

View raw message