Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Message-ID: <4043EADD.7060201@attglobal.net>
Date: Mon, 01 Mar 2004 21:01:01 -0500
From: Jeff Trawick <trawick@attglobal.net>
User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.5) Gecko/20031020
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: cvs commit: apr/threadproc/win32 thread.c
References: <20040301210544.93095.qmail@minotaur.apache.org>
 <4043B5E1.7080201@attglobal.net>
 <6.0.2.0.2.20040301172512.04230e08@pop3.rowe-clan.net>
In-Reply-To: <6.0.2.0.2.20040301172512.04230e08@pop3.rowe-clan.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

William A. Rowe, Jr. wrote:
> At 04:14 PM 3/1/2004, Jeff Trawick wrote:
> 
>>trawick@apache.org wrote:
>>
>>>trawick     2004/03/01 13:05:44
>>>              threadproc/win32 thread.c
>>
>>> 1.56      +14 -2     apr/threadproc/win32/thread.c
>>> 
>>> Index: thread.c
>>> ===================================================================
>>> RCS file: /home/cvs/apr/threadproc/win32/thread.c,v
>>> retrieving revision 1.55
>>> retrieving revision 1.56
>>> diff -u -r1.55 -r1.56
>>> --- thread.c  13 Feb 2004 09:38:38 -0000      1.55
>>> +++ thread.c  1 Mar 2004 21:05:44 -0000       1.56
>>> @@ -38,6 +38,9 @@
>>>      }
>>>  
>>>      (*new)->pool = pool;
>>> +    (*new)->detach = 0;
>>
>>btw, detach was previously uninitialized storage; I dunno what the real-world repurcussions of that are
> 
> 
> if it was opaque, is alloc'ed and assigned consistently  - then the only side
> effect are the odds that some cases were previously misinterpreted as 
> detached.  This would have caused ugly side effects, so your patch is fine.

I was just curious about how harmful in practical terms the occasional 
CloseHandle() on the thread handle would be...