apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: apr/threadproc/win32 thread.c
Date Tue, 02 Mar 2004 06:38:38 GMT
At 08:01 PM 3/1/2004, Jeff Trawick wrote:
>William A. Rowe, Jr. wrote:
>>At 04:14 PM 3/1/2004, Jeff Trawick wrote:
>>>trawick@apache.org wrote:
>>>>     (*new)->pool = pool;
>>>>+    (*new)->detach = 0;
>>>btw, detach was previously uninitialized storage; I dunno what the real-world
repurcussions of that are
>>if it was opaque, is alloc'ed and assigned consistently  - then the only side
>>effect are the odds that some cases were previously misinterpreted as detached.  This
would have caused ugly side effects, so your patch is fine.
>I was just curious about how harmful in practical terms the occasional CloseHandle() on
the thread handle would be...

I missed the gist of your Q - 18 mos ago I walked through all the cases when
the proc handles were used - time to repeat for proc and thread handles.


View raw message