apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] LFS support for 1.0, take 2
Date Wed, 24 Mar 2004 15:11:29 GMT
Joe Orton wrote:

> Thanks, added that too with the configure check for sendfilev64.  Take 3
> is about ready to be committed, I think.

I can't imagine any showstoppers at this point.  Committing real soon seems to 
be the right thing to do.

> TODO:
> 
> * test the sendfile thunks work
> * adjust ssize_t rc handling for HP-UX sendfile64 case
> 
> CHANGES:
> 
> * have apr_file_mktemp use mkstemp64 where available
> * use CuNotImpl rather than fail testlfs when the truncate gets E2BIG
>   (usually due to rlimit or fs limits)
> * sendfile foo:
>  - Solaris: sendfilev64 + adjusted casts

Note that these lines now generate a gcc 3.2 warning for casting from a pointer 
to an integer of a different size (32 bits into 64 bits).  But the Solaris API 
is such that you have to stuff a pointer to an integer.

+        sfv[curvec].sfv_off = (apr_off_t)hdtr->trailers[i].iov_base;

I don't know of an elegant fix to silence the warning.

Mime
View raw message