apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: RFC: Unix LFS support for 1.0
Date Mon, 22 Mar 2004 14:53:11 GMT
Joe Orton wrote:
> On Mon, Mar 22, 2004 at 09:16:02AM -0500, Jeff Trawick wrote:
> 
>>Joe Orton wrote:
>>
>>>- what to do about old Linux 2.2's which have no sendfile64(): disable
>>>sendfile support, or disable LFS support? both change the ABI
>>
>>from an ABI standpoint (given that there is no 1.0 ABI yet), it seems safer 
>>to turn off sendfile support and turn on lfs support when sendfile and lfs 
>>conflict...   if an app was built without APR_HAS_SENDFILE and the user 
>>upgraded the OS and rebuilt apr such that apr could support both sendfile 
>>and lfs, the old app binary would still work fine with the new apr, since 
>>adding the sendfile capability would not change the interface to existing 
>>capabilities
> 
> 
> I looked through the various dicussions about this previously...
> 
> How about this: for the Linux case APR_HAS_LARGE_FILES &&
> !defined(HAVE_SENDFILE64) && sizeof(off_t) == 4, just define
> apr_socket_sendfile() as a wrapper which returns EINVAL if passed
> (*offset + *len) > INT_MAX, and otherwise handles thunking between the
> off64_t and off_t correctly for <2gb files?

+1

Mime
View raw message