apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@rkbloom.net
Subject Re: [PATCH] fix warnings in test/sockchild.c
Date Mon, 15 Mar 2004 01:47:46 GMT

I'll apply this later tonight.  Ever since writing this test, I have been trying
to make it work on Windows.

Ryan

Quoting Garrett Rooney <rooneg@electricjellyfish.net>:

> The new sockchild.c file has a few warnings on OS X.
> 
> /bin/sh /Users/rooneg/Hacking/apr/libtool --silent --mode=compile gcc 
> -g -O2   -DHAVE_CONFIG_H -DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK 
> -no-cpp-precomp   -I../include  -o sockchild.lo -c sockchild.c && touch 
> sockchild.lo
> sockchild.c: In function `main':
> sockchild.c:57: warning: passing arg 3 of `apr_socket_recv' from 
> incompatible pointer type
> sockchild.c:71: warning: passing arg 3 of `apr_socket_send' from 
> incompatible pointer type
> 
> Here's a patch to correct them.
> 
> -garrett
> 
> Index: test/sockchild.c
> ===================================================================
> RCS file: /home/cvspublic/apr/test/sockchild.c,v
> retrieving revision 1.1
> diff -u -r1.1 sockchild.c
> --- test/sockchild.c    14 Mar 2004 20:30:20 -0000      1.1
> +++ test/sockchild.c    15 Mar 2004 00:38:30 -0000
> @@ -52,7 +52,7 @@
> 
>       if (!strcmp("read", argv[1])) {
>           char datarecv[STRLEN];
> -        int length = STRLEN;
> +        apr_size_t length = STRLEN;
> 
>           apr_status_t rv = apr_socket_recv(sock, datarecv, &length);
>           apr_socket_close(sock);
> @@ -67,7 +67,7 @@
>           exit(length);
>       }
>       else if (!strcmp("write", argv[1])) {
> -        int length = strlen(DATASTR);
> +        apr_size_t length = strlen(DATASTR);
>           apr_socket_send(sock, DATASTR, &length);
> 
>           apr_socket_close(sock);
> 
> 




Mime
View raw message