apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@rkbloom.net
Subject Re: cvs commit: apr/test testfnmatch.c Makefile.in Makefile.win test_apr.h testall.c
Date Sat, 06 Mar 2004 21:09:05 GMT
Quoting Joe Orton <joe@manyfish.co.uk>:

> On Fri, Mar 05, 2004 at 07:52:06PM -0000, Ryan Bloom wrote:
> > rbb         2004/03/05 11:52:06
> > 
> >   Modified:    include  apr_fnmatch.h
> >                strings  apr_fnmatch.c
> >                test     Makefile.in Makefile.win test_apr.h testall.c
> >   Added:       test     testfnmatch.c
> >   Log:
> >   Add apr_match_glob and two tests to make sure that it is working.  There
> >   is a problem that is documented in the code that requires an
> >   apr_filepath_basename.  That will be added soon.
> 
> Are you planning to extend this into a real glob() implementation (i.e.
> handling "*/*" etc)?  If not I don't think it should be named _glob(),
> apr_fnmatch_expand() or something might be more appropriate.

yeah, we should expand it.  I wrote what I needed immediately, but it should
definately work like glob works.  I'll look into extending this soon-ish, unless
somebody wants to beat me to it.

Ryan

Mime
View raw message