apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: Date limit in apr_time_exp_get
Date Tue, 23 Mar 2004 01:11:39 GMT
On Monday, March 22, 2004, at 04:00  PM, Philip Martin wrote:
> This code in apr_time_exp_get:
>
>     year = xt->tm_year;
>     if (year < 70 || ((sizeof(time_t) <= 4) && (year >= 138))) {
>         return APR_EBADDATE;
>     }
>
> rejects all 2038 dates even though all the 2038 dates up to
> 2038-01-19T03:14:07.000000Z will fit into a 32-bit time_t.
> apr_time_exp_gmt  doesn't reject these dates.

Another bug due to a sloppy change from time_t to apr_time_t.
Change days to apr_time_t and remove the above conditional
(the case of year < 70 is already handled a few lines below).

....Roy


Mime
View raw message