From dev-return-11064-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Feb 19 22:15:33 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 72541 invoked from network); 19 Feb 2004 22:15:33 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 19 Feb 2004 22:15:33 -0000 Received: (qmail 10311 invoked by uid 500); 19 Feb 2004 22:15:19 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 10272 invoked by uid 500); 19 Feb 2004 22:15:19 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 10216 invoked from network); 19 Feb 2004 22:15:15 -0000 From: "Brian Havard" To: "dev@apr.apache.org" Date: Fri, 20 Feb 2004 09:15:19 +1000 (EST) Reply-To: "Brian Havard" Priority: Normal X-Mailer: PMMail 2.20.2382 for OS/2 Warp 4.5 In-Reply-To: <20040218224100.GA12759@manyfish.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: Fix build on amd64 platform by importing new config.{guess,sub} Message-Id: X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Wed, 18 Feb 2004 22:41:00 +0000, Joe Orton wrote: >On Thu, Feb 19, 2004 at 09:11:40AM +1000, Brian Havard wrote: >> >Some of these platforms are probably already broken with the new >> >gen-build changes since build-outputs.mk doesn't know about $(OSDIR). >> >> Yeah, I noticed the build was broken on OS/2, tries to compile >> dso/unix/dso.c. >> So how do you test for the platform in python? Obviously gen-build.py's >> get_platform() needs some work... > >I think the {platform} thing in build.conf in general needs some work... > >> The script also needs to be smarter in that the OSDIR is optional, falling >> back to unix if there's no OSDIR (EG apr/memory) which doesn't happen if I >> simply change get_platform() to return "os2". > >Really gen-build.py needs to create a build-outputs.mk which is >appropriate for all platforms which use configure & Makefile, with an >OBJECTS which uses $(OSDIR) and $(DEFAULT_OSDIR) as determined by >configure (though since DEFAULT_OSDIR is a constant for the Unix build >system that could be eliminated). Ah yes, I was forgetting that gen-build.py's output needs to work on all platforms, not just the one it's run on so its get_platform() won't help. I'll have a look at it if I get some time though I don't know much python... -- ______________________________________________________________________________ | Brian Havard | "He is not the messiah! | | brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian | ------------------------------------------------------------------------------