apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grega...@apache.org
Subject Re: [PATCH] don't overlay storage selecting on big fd
Date Mon, 16 Feb 2004 15:25:13 GMT
Jeff Trawick wrote:
> FD_SET is rather unfriendly if you give it a file descriptor that is >= 
> FD_SETSIZE.  It will overlay storage.

> Any comments?  Yeah, the error code sucks.  APR_ENOPOLL?  APR_ENOSOCKET?

What's wrong with APR_EBADF?  That give me a good hint of what the problem is
without having to grep/Google/look stuff up.

Greg

> +#if !defined(WIN32) /* socket sets handled with array of handles */
> +    if (fd >= FD_SETSIZE) {
> +        /* XXX invent new error code so application has a clue */
> +        return APR_EBADF;
> +    }



Mime
View raw message